test: Updates all test workflows to use advanced_cluster TPF implementation #3580
Conversation
|
failing check is unrelated to this PR |
There was a problem hiding this comment.
Pull Request Overview
This PR fixes test suite failures by addressing HCL configuration generation issues and test compatibility problems. The changes focus on correcting Terraform configuration syntax and ensuring proper test execution.
- Updates HCL configuration generation to use TupleVal instead of ListVal for better type flexibility
- Fixes Terraform configuration syntax in test files to use proper assignment operators
- Adds version compatibility checks for migration tests
Reviewed Changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| internal/testutil/acc/config_cluster.go | Refactors variable names, fixes indentation, and changes from ListVal to TupleVal for replication specs |
| internal/serviceapi/searchdeploymentapi/resource_test.go | Updates cluster configuration syntax from block to assignment format |
| internal/service/clusteroutagesimulation/resource_test.go | Adds blank line for import formatting |
| internal/service/clusteroutagesimulation/resource_migration_test.go | Adds version compatibility checks for migration tests |
| .github/workflows/code-health.yml | Changes reduced_tests flag to true for workflow optimization |
maastha
changed the title
| @@ -14,7 +14,7 @@ on: | |||
| type: string | |||
| required: false | |||
| test_group: | |||
| description: 'Test group to run, e.g. advanced_cluster, empty for all' | |||
| description: 'Test group to run, e.g. advanced_cluster_tpf, empty for all' | |||
There was a problem hiding this comment.
what about renaming all occurences in this file from advanced_cluster_tpf to advanced_cluster as that's the only one now?
| @@ -436,7 +431,7 @@ jobs: | |||
| MONGODB_ATLAS_LAST_1X_VERSION: ${{ inputs.mongodb_atlas_last_1x_version }} | |||
| ACCTEST_REGEX_RUN: '^TestMig' | |||
| ACCTEST_PACKAGES: | | |||
| ./internal/service/advancedcluster | |||
| ./internal/service/advancedclustertpf | |||
There was a problem hiding this comment.
do we still need advanced_cluster_tpf_mig_from_sdkv2 tests? Maybe we can remove it, and remove logic associated with env.var MONGODB_ATLAS_TEST_SDKV2_TO_TPF from the code.
| } | ||
| rcMap["auto_scaling"] = cty.ObjectVal(map[string]cty.Value{ | ||
| "disk_gb_enabled": cty.BoolVal(asDisk.GetEnabled()), | ||
| }) | ||
| } | ||
|
|
||
| nodeSpec := rc.GetElectableSpecs() | ||
| es := rc.GetElectableSpecs() |
There was a problem hiding this comment.
are these changes related with test workflow changes?
| @@ -91,4 +91,4 @@ jobs: | |||
| secrets: inherit | |||
| uses: ./.github/workflows/acceptance-tests.yml | |||
| with: | |||
| reduced_tests: false | |||
| reduced_tests: true | |||
There was a problem hiding this comment.
can you clarify here the why?
| @@ -14,7 +14,7 @@ on: | |||
| type: string | |||
| required: false | |||
| test_group: | |||
| description: 'Test group to run, e.g. advanced_cluster, empty for all' | |||
| description: 'Test group to run, e.g. advanced_cluster_tpf, empty for all' | |||
There was a problem hiding this comment.
curious about the context: why do we still need to specify the _tpf?
There was a problem hiding this comment.
i made a similar comment, we can remove tpf now that it's the only test group
Description
Test suite run: https://github.com/mongodb/terraform-provider-mongodbatlas/actions/runs/16890016640
This PR also addresses all remaining code changes mentioned in CLOUDP-336437
Link to any related issue(s): CLOUDP-336437
Type of change:
Required Checklist:
Further comments